Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when last updated by has nil ID #435

Merged
merged 6 commits into from
Feb 8, 2020
Merged

Fix crash when last updated by has nil ID #435

merged 6 commits into from
Feb 8, 2020
+19 −12

Conversation

NicholasCF
Copy link
Contributor

@NicholasCF NicholasCF commented Feb 1, 2020 •
edited
Loading

Close #348

Encountered this error:

Error: unrecognized cop Rails found in .rubocop.yml, unrecognized cop Rails/HasAndBelongsToMany found in .rubocop.yml, unrecognized cop Rails/SaveBang found in .rubocop.yml

@chrisjwelly chrisjwelly temporarily deployed to dutycommit-pr-435 February 1, 2020 03:05 Inactive
@NicholasCF NicholasCF force-pushed the deleted-updater-problem-report branch from 2047929 to b2a227c Compare February 7, 2020 06:58
chrisjwelly
chrisjwelly approved these changes Feb 8, 2020
View reviewed changes
Copy link
Member

@chrisjwelly chrisjwelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉
Thanks!

@chrisjwelly chrisjwelly merged commit 5b7723c into master Feb 8, 2020
@ryoarmanda ryoarmanda deleted the deleted-updater-problem-report branch March 29, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisjwelly chrisjwelly chrisjwelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to show all problem reports
2 participants
@NicholasCF @chrisjwelly